Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable remindAll button even after event start. #2532

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

dev-di
Copy link
Contributor

@dev-di dev-di commented Feb 2, 2025

The remindAll button now shows both before the event and during the event

Description

In the event page, participant tab, there is a button for sending reminders. Before this change, this button is only available before the event start date.

Logic after this change:

  • Before event start: Show remindAll button (as before)
  • During the event: Still show the remindAll button (new logic)
  • After the event: Do not show the remindAll (as before)

Screenshots

How it looks during the event. You could still send reminders.
image

Changes

  • Adding the remindAll button when inbetween event.start_date and event.end_date
  • Refactor the remindAll section into a component for easier readability

Notes to reviewer

You find more details in the issue #2433

Try manipulating the event start-date and end-date for all 3 possible cases:

  • Before event start
  • During the event
  • After the event

Related issues

Resolves #2433

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Can't send reminders after event starts
1 participant